Add '線上聲請平台' endpoint to the sidebar, based on 建班評公字第08023000001號.#300
Add '線上聲請平台' endpoint to the sidebar, based on 建班評公字第08023000001號.#300RobotHanzo merged 4 commits intoCKStudentCouncil:mainfrom
建班評公字第08023000001號.#300Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the sidebar navigation in HeaderSidebar.vue to include a new menu item linking users to the external “線上聲請平台”.
Changes:
- Added a new sidebar endpoint labeled “線上聲請平台” pointing to an external Notion URL.
- Marked the new endpoint as
external: trueandrequireAuth: false.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/layouts/HeaderSidebar.vue
Outdated
| { name: '編輯法令', url: '/manage/legislation', icon: 'edit', requireAuth: true }, | ||
| { name: '編輯公文', url: '/manage/document', icon: 'draw', requireAuth: true }, | ||
| { name: '評委文書', url: '/document/judicial', icon: 'balance', requireAuth: false }, | ||
| { name: '線上聲請平台', url: 'https://cksc-jc.notion.site/38a4465929c78260b6d681378aba8efc ', icon: 'launch', external: true, requireAuth: false }, |
There was a problem hiding this comment.
external: true is added on the endpoint, but the template always renders <q-item :to="endpoint.url">. In Quasar/Vue Router, to is for internal routes; passing an absolute https URL is likely to be treated as a router path and won’t open the external site. Please update the rendering logic to use href/target (and ideally rel="noopener noreferrer") for endpoint.external items, while keeping to for internal routes.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request adds a new external link to the sidebar navigation in
HeaderSidebar.vue, allowing users to access the online application platform directly from the menu.Navigation update: